New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: launch ephemeral containers targetting containers running with non root access #4288

Merged

gireesh-devtron merged 11 commits into main from ephemeral-container-non-root-support

Dec 4, 2023

Member

gireesh-devtron commented Nov 25, 2023 •

edited

Description

Fixes #4289

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

gireesh-devtron added 9 commits

November 24, 2023 17:43


          creating ephemeral script in tmp folder

9658de1


          cyclic dependency fix and remove unused test file

4fe199b


          var name update

184461e


          moved ephemeral containers common logic to common lib

191935b


          common-lib version bump

8dc4d96


          common-lib version bump

676b47c


          common-lib version bump

d22f3a2


          setting ephemeral containers in get pod resource api

a63d4e3


          bump common-lib

f93acb6

gireesh-devtron requested review from vikramdevtron, kripanshdevtron and nishant-d as code owners

November 25, 2023 09:33

github-actions bot added PR:Issue-verification-failed PR:Ready-to-Review and removed PR:Issue-verification-failed labels

gireesh-devtron added 2 commits

November 28, 2023 18:32


          use constant

2b53e53


          common-lib version bump

0c50864

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

kripanshdevtron approved these changes

View reviewed changes

gireesh-devtron merged commit 82e399c into main

6 checks passed

gireesh-devtron deleted the ephemeral-container-non-root-support branch

December 4, 2023 10:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment