Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get Artifacts list API is throwing pg no rows error #4292

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix: Get Artifacts list API is throwing pg no rows error #4292

merged 2 commits into from
Nov 27, 2023

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Nov 27, 2023

Description

After enabling artifacts V2 flag, get material list API is breaking for external CI and job CI (Throwing error: pg: no rows in result set)

Fixes #4290

How Has This Been Tested?

  • Job CI
    • Approval list
    • Pre CD list
    • CD list
    • Post CD list
  • External CI
    • Approval list
    • Pre CD list
    • CD list
    • Post CD list
  • Build CI
    • Approval list
    • Pre CD list
    • CD list
    • Post CD list
  • Link CI
    • Approval list
    • Pre CD list
    • CD list
    • Post CD list

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ash-exp Ash-exp added the enhancement New feature or request label Nov 27, 2023
@Ash-exp Ash-exp self-assigned this Nov 27, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ash-exp Ash-exp merged commit 4bb931d into main Nov 27, 2023
5 checks passed
@Ash-exp Ash-exp deleted the fix-artifacts-list branch November 27, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamayushm iamayushm iamayushm approved these changes

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees

@Ash-exp Ash-exp

Labels
enhancement New feature or request PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Not able to view images in case of External CI
3 participants
@Ash-exp @iamayushm @vikramdevtron