Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhancements in User Service and User common service #4293

Merged
merged 128 commits into from
Dec 13, 2023

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Nov 27, 2023

Description

Fixes #4278

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Base automatically changed from feat-rbac-in-jobs to main December 4, 2023 13:50
internal/sql/repository/app/AppRepository.go Show resolved Hide resolved
pkg/user/UserAuthService.go Outdated Show resolved Hide resolved
pkg/user/UserCommonService.go Show resolved Hide resolved
pkg/user/repository/bean.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Shivam-nagar23 Shivam-nagar23 merged commit d67ae5a into main Dec 13, 2023
3 of 4 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the chore-enhancements-in-rbac branch December 13, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Optimisations and Refactoring around User Service.
3 participants