Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app-group page breaking for inactive users #4315

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Conversation

ashishdevtron
Copy link
Contributor

@ashishdevtron ashishdevtron commented Nov 29, 2023

Description

fixes the issue where page breaks in app group when opening an environment of user which is already deleted

Fixes #4316

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@ashishdevtron ashishdevtron changed the title fix: added logger and removed return statement fix: app-group page breaking for inactive users Nov 30, 2023
pkg/app/AppListingService.go Outdated Show resolved Hide resolved
kartik-579
kartik-579 previously approved these changes Nov 30, 2023
return resp, err
}
for _, envContainer := range envContainers {
lastDeployed, err := impl.appListingRepository.FetchLastDeployedImage(envContainer.AppId, envId)
if err != nil {
impl.Logger.Errorw("failed to fetch last deployed image", "err", err, "app id", envContainer.AppId, "env id", envId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use camelCase for param keys like appId instead of app id

Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ashishdevtron ashishdevtron merged commit 58deb41 into main Nov 30, 2023
5 checks passed
@ashishdevtron ashishdevtron deleted the app-group-fix branch November 30, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Overview Page in Application group breaking
3 participants