Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:cve search #4347

Merged
merged 4 commits into from
Dec 6, 2023
Merged

fix:cve search #4347

merged 4 commits into from
Dec 6, 2023

Conversation

ShashwatDadhich
Copy link
Contributor

@ShashwatDadhich ShashwatDadhich commented Dec 5, 2023 •
edited

Description

Fix for CVE Policy search

Fixes #4361

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

gireesh-devtron
gireesh-devtron reviewed Dec 5, 2023
View reviewed changes
pkg/security/ImageScanService.go Outdated Show resolved Hide resolved
pkg/security/ImageScanService.go Outdated Show resolved Hide resolved
internal/sql/repository/security/CveStoreRepository.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ShashwatDadhich ShashwatDadhich changed the title CVE search fix fix:cve search Dec 5, 2023
@ShashwatDadhich ShashwatDadhich merged commit 93ecb69 into main Dec 6, 2023
5 of 10 checks passed
@ShashwatDadhich ShashwatDadhich deleted the cve_search_fix branch December 6, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireesh-devtron gireesh-devtron gireesh-devtron left review comments

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: CVE policy search breaking
3 participants
@ShashwatDadhich @kripanshdevtron @gireesh-devtron