Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing clusterConfig in releaseIdentifier request #4359

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

gireesh-devtron
Copy link
Member

@gireesh-devtron gireesh-devtron commented Dec 6, 2023

Description

Fixes #4360

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


kripanshdevtron
kripanshdevtron previously approved these changes Dec 6, 2023
adi6859
adi6859 previously approved these changes Dec 6, 2023
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gireesh-devtron gireesh-devtron merged commit b886994 into main Dec 6, 2023
5 of 8 checks passed
@gireesh-devtron gireesh-devtron deleted the cluster-config-nil-ptr branch December 6, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: For some helm application notes are not visible
4 participants