Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove the annotation hook from devtron-nats-test-request-reply pod #4387

Merged
merged 1 commit into from
Dec 12, 2023
Merged

chore: Remove the annotation hook from devtron-nats-test-request-reply pod #4387

merged 1 commit into from
Dec 12, 2023

Conversation

ajaydevtron
Copy link
Contributor

@ajaydevtron ajaydevtron commented Dec 12, 2023

Description

Remove the test hook annotation from devtron-nats-test-request-reply pod from nats-server.yaml .

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

sonarcloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ajaydevtron ajaydevtron changed the title Fix: Remove the annotation hook from devtron-nats-test-request-reply pod chore: Remove the annotation hook from devtron-nats-test-request-reply pod Dec 12, 2023
@prakarsh-dt prakarsh-dt merged commit 25b8756 into devtron-labs:main Dec 12, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants