Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: common-lib version update #4399

Merged
merged 5 commits into from
Dec 19, 2023
Merged

feat: common-lib version update #4399

merged 5 commits into from
Dec 19, 2023

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Dec 13, 2023

Description:

In case of pub sub client if the callback process throws panic, the consumer micro service gets killed abruptly. Also the faulty event doesn't get acknowledged and marked for redelivery in the message queue. This causes an issue where our micro service gets multiple restarts as we process the faulty event in an infinite loop.

To tackle this issue we can recover panic gracefully and publish an event with the required informations and logs for quick support/ fix. Also graceful recovery will ensure no downtime for the consumer service.

Fixes #4395

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link
Member

@gireesh-devtron gireesh-devtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ash-exp Ash-exp merged commit 4abad59 into main Dec 19, 2023
5 of 8 checks passed
@Ash-exp Ash-exp deleted the feat-panic-handling branch December 19, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Panic recovery in NATS event subscription.
3 participants