Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependabot version upgrade nats metrics oss #4453

Merged
merged 42 commits into from
Dec 27, 2023

Conversation

gireesh-devtron
Copy link
Member

@gireesh-devtron gireesh-devtron commented Dec 22, 2023

Description

  1. Updated the versions for depenadbot security for kubernetes, argo-cd, otelgrpc, gRPC, swift, goProxy etc.
  2. added pub-sub metrics

Fixes issue

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

adi6859
adi6859 previously approved these changes Dec 22, 2023
Copy link

gitguardian bot commented Dec 26, 2023

⚠️ GitGuardian has uncovered 31 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8891374 RSA Private Key 4ab8404 vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_key.pem View secret
8891374 RSA Private Key 57f9b7f vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/server_key.pem View secret
8891374 RSA Private Key 6f4ca45 vendor/github.com/google/s2a-go/internal/v2/testdata/server_key.pem View secret
8891374 RSA Private Key 3b8ad0c vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_key.pem View secret
8891374 RSA Private Key 407e149 vendor/github.com/google/s2a-go/internal/v2/testdata/server_key.pem View secret
8891374 RSA Private Key 407e149 vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/server_key.pem View secret
8891374 RSA Private Key 3b8ad0c vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/server_key.pem View secret
8891374 RSA Private Key 407e149 vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_key.pem View secret
8891374 RSA Private Key 57f9b7f vendor/github.com/google/s2a-go/testdata/server_key.pem View secret
8891374 RSA Private Key 3b8ad0c vendor/github.com/google/s2a-go/internal/v2/testdata/server_key.pem View secret
8891374 RSA Private Key 6f4ca45 vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_key.pem View secret
8891374 RSA Private Key 4ab8404 vendor/github.com/google/s2a-go/internal/v2/testdata/server_key.pem View secret
8891374 RSA Private Key 57f9b7f vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_key.pem View secret
8891374 RSA Private Key 57f9b7f vendor/github.com/google/s2a-go/internal/v2/testdata/server_key.pem View secret
8891374 RSA Private Key 4ab8404 vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/server_key.pem View secret
8891379 RSA Private Key 3b8ad0c vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_key.pem View secret
8891379 RSA Private Key 407e149 vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_key.pem View secret
8891379 RSA Private Key 6f4ca45 vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_key.pem View secret
8891379 RSA Private Key 407e149 vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_key.pem View secret
8891379 RSA Private Key 407e149 vendor/github.com/google/s2a-go/internal/v2/testdata/client_key.pem View secret
8891379 RSA Private Key 4ab8404 vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_key.pem View secret
8891379 RSA Private Key 4ab8404 vendor/github.com/google/s2a-go/internal/v2/testdata/client_key.pem View secret
8891379 RSA Private Key 57f9b7f vendor/github.com/google/s2a-go/internal/v2/testdata/client_key.pem View secret
8891379 RSA Private Key 57f9b7f vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_key.pem View secret
8891379 RSA Private Key 57f9b7f vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_key.pem View secret
8891379 RSA Private Key 57f9b7f vendor/github.com/google/s2a-go/testdata/client_key.pem View secret
8891379 RSA Private Key 3b8ad0c vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_key.pem View secret
8891379 RSA Private Key 4ab8404 vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_key.pem View secret
8891379 RSA Private Key 6f4ca45 vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_key.pem View secret
8891379 RSA Private Key 6f4ca45 vendor/github.com/google/s2a-go/internal/v2/testdata/client_key.pem View secret
8891379 RSA Private Key 3b8ad0c vendor/github.com/google/s2a-go/internal/v2/testdata/client_key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gireesh-devtron gireesh-devtron changed the title chore: dependabot version upgrade nats metrics oss fix: dependabot version upgrade nats metrics oss Dec 26, 2023
@gireesh-devtron gireesh-devtron changed the title fix: dependabot version upgrade nats metrics oss chore: dependabot version upgrade nats metrics oss Dec 26, 2023
Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gireesh-devtron gireesh-devtron merged commit 3841d75 into main Dec 27, 2023
5 checks passed
@gireesh-devtron gireesh-devtron deleted the dependabot_version_upgrade_nats-metrics-oss branch December 27, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants