Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app clone breaking if ci pipeline have same name #4461

Merged
merged 15 commits into from
Dec 28, 2023
Merged

fix: app clone breaking if ci pipeline have same name #4461

merged 15 commits into from
Dec 28, 2023

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Dec 26, 2023 •
edited

Description

Fixes #4459

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  1. Clone existed app with duplicate CI pipeline.
  2. Cloned the Cloned app.
  3. Cloned with CD piplines.
  4. Deployed in cloned app.
  5. Clone existed app NORMAL pipeline.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@iamayushm iamayushm changed the title wip: making name unique for app clone fix: app clone breaking if ci pipeline have same name Dec 28, 2023
@iamayushm iamayushm merged commit 6b596a8 into main Dec 28, 2023
7 checks passed
@iamayushm iamayushm deleted the fix-dup-ci-pipeline-name branch December 28, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d approved these changes

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: app clone breaking if CI Pipeline Name is duplicated within same application across workflows
3 participants
@iamayushm @nishant-d @vikramdevtron