Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds support for gRPC in health probes #4495

Merged
merged 12 commits into from
Jan 12, 2024

deleted ref 4.19

fb3f769
Select commit
Loading
Failed to load commit list.
Merged

feat: Adds support for gRPC in health probes #4495

deleted ref 4.19
fb3f769
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks completed Jan 11, 2024 in 32s

9 secrets uncovered!

9 secrets were uncovered from the scan of 12 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #4495: main 👉 main
GitGuardian id Secret Commit Filename
- Base64 AWS keys 3a7e0d0 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json View secret
- Generic High Entropy Secret 3a7e0d0 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml View secret
- Generic High Entropy Secret 1e5ee97 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
- Generic High Entropy Secret 3a7e0d0 scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml View secret
- Generic High Entropy Secret fb3f769 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
- Generic High Entropy Secret 3a7e0d0 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml View secret
- Generic High Entropy Secret 1e5ee97 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
- Generic High Entropy Secret fb3f769 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
- Generic High Entropy Secret 3a7e0d0 scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!