Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag + Image Digest at CD #4507

Merged
merged 9 commits into from
Feb 23, 2024
Merged

docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag + Image Digest at CD #4507

merged 9 commits into from
Feb 23, 2024

Conversation

ashokdevtron
Copy link
Contributor

@ashokdevtron ashokdevtron commented Jan 4, 2024 •
edited

Completed:

  • Workflow updated with snapshots
  • CI document restructured and updated (Image Tag included)
  • CD document restructured and updated (Tag and Approval included)
  • Copy Container Image plugin added (Skopeo)
  • RBAC
  • Image Digest at CD included and GC added

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashokdevtron ashokdevtron changed the title Revamp approvaldoc docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag at CD Jan 4, 2024
abhibhaw
abhibhaw requested changes Jan 6, 2024
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to include latest images having digest options as well. And maybe we can handle that too with this. Also we need to give some ideal pipelines (Devtron recommended) with this doc

uxarya-d
uxarya-d requested changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@uxarya-d uxarya-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review comments

docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md Show resolved Hide resolved
docs/user-guide/deploying-application/triggering-cd.md Show resolved Hide resolved
docs/user-guide/deploying-application/triggering-cd.md Outdated Show resolved Hide resolved
@ashokdevtron ashokdevtron changed the title docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag at CD docs: Workflow + Skopeo + Approval + Image Tag at CI + Image Tag + Image Digest at CD Feb 13, 2024
abhibhaw
abhibhaw requested changes Feb 17, 2024
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the content is great, and we have covered all the topics in detail, one concern I have is repetition. A lot of same / similar content in repeated this will make it harder for us to manage and for users it may be confusing as while I was reading every time it was in my mind I think I read this few lines above.

docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/cd-pipeline.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md Outdated Show resolved Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md Show resolved Hide resolved
docs/user-guide/creating-application/workflow/plugins/copy-container-image.md Show resolved Hide resolved
docs/user-guide/global-configurations/pull-image-digest.md Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashokdevtron ashokdevtron dismissed abhibhaw’s stale review February 23, 2024 14:05

Changes have been incorporated

@ashokdevtron ashokdevtron merged commit 63741cb into main Feb 23, 2024
5 checks passed
@ashokdevtron ashokdevtron deleted the revamp-approvaldoc branch February 23, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uxarya-d uxarya-d uxarya-d approved these changes

@abhibhaw abhibhaw abhibhaw left review comments

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashokdevtron @abhibhaw @uxarya-d