Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for downloading pod logs #4539

Merged
merged 27 commits into from
Feb 5, 2024
Merged

Conversation

ashishdevtron
Copy link
Contributor

@ashishdevtron ashishdevtron commented Jan 12, 2024

Description

Fixes #4334

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@ashishdevtron ashishdevtron changed the title Pod logs download v2 added support for downloading pod logs Jan 12, 2024
@kartik-579
Copy link
Member

add semantic title

@kartik-579
Copy link
Member

link issue

@ashishdevtron ashishdevtron changed the title added support for downloading pod logs feat: added support for downloading pod logs Jan 24, 2024
api/k8s/application/k8sApplicationRestHandler.go Outdated Show resolved Hide resolved
api/k8s/application/k8sApplicationRestHandler.go Outdated Show resolved Hide resolved
api/k8s/application/k8sApplicationRestHandler.go Outdated Show resolved Hide resolved
api/k8s/application/k8sApplicationRestHandler.go Outdated Show resolved Hide resolved
api/k8s/application/k8sApplicationRouter.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ashishdevtron ashishdevtron merged commit 95f7e2d into main Feb 5, 2024
5 checks passed
@ashishdevtron ashishdevtron deleted the pod-logs-download-v2 branch February 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support to download logs from Dashboard
3 participants