Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: code refactoring v1 #4545

Merged
merged 7 commits into from
Jan 24, 2024
Merged

chore: code refactoring v1 #4545

merged 7 commits into from
Jan 24, 2024

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Jan 15, 2024 •
edited

Description

App Store Code refactoring Version 1.0

  1. Fixed Folder structure for chart group
  2. Removed dead code.
  3. Removed Jira Integration
  4. Removed unused tables

How Has This Been Tested?

  • Sanity Testing For App Store

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

nishant-d and others added 4 commits January 15, 2024 16:52
@nishant-d @Ash-exp
chore: Removed unused jira and migration integration (#4498)
c7cfc9e 
* removed unsued jira integration

* removed test-suite-code

* db migration conf removal

* chore: removed unused injection

* chore: removed dead code

* added: migration script

---------

Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
@nishant-d @Ash-exp
chore: App store dead code cleanup and restructuring (#4497)
28b07fd 
* moved chart-group in seperate code

* removed unused dependency

* removed dead code

* extracted resource tree

* moved notes

* resource movement

* removed unused code

* removed unused dependency

* commit methods

* extracted status update

* chore: clean up unused dead code

* updated: EA mode docker file

* updated: migration number

---------

Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
@Ash-exp
moved: const and types to bean
acfec88
@Ash-exp
removed: unused const
0eb82b7
@Ash-exp Ash-exp added the enhancement New feature or request label Jan 15, 2024
@Ash-exp Ash-exp self-assigned this Jan 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

6.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Ash-exp Ash-exp merged commit e256f1c into main Jan 24, 2024
3 of 4 checks passed
@Ash-exp Ash-exp deleted the chore-refactoring-v1 branch January 24, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

Assignees

@Ash-exp Ash-exp

Labels
enhancement New feature or request PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ash-exp @nishant-d