Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5xx 3.0 #4578

Merged
merged 37 commits into from
Feb 20, 2024
Merged

fix: 5xx 3.0 #4578

merged 37 commits into from
Feb 20, 2024

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Jan 22, 2024

Description

Fixes #4701

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


# Conflicts:
#	go.mod
#	go.sum
#	pkg/pipeline/CiService.go
#	vendor/github.com/devtron-labs/common-lib/pubsub-lib/PubSubClientService.go
#	vendor/modules.txt
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prakash100198 prakash100198 merged commit 6d3c79d into main Feb 20, 2024
4 of 5 checks passed
@prakash100198 prakash100198 deleted the 5xx-3.0 branch February 20, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: third iteration for multiple APIs throw unnecessary 5xx, even though it's not a 5xx error
2 participants