Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implemented cache for storing cloud provider #4591

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Conversation

ashishdevtron
Copy link
Contributor

@ashishdevtron ashishdevtron commented Jan 25, 2024

Description

Fixes #4594

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


client/telemetry/TelemetryEventClient.go Outdated Show resolved Hide resolved
client/telemetry/TelemetryEventClient.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

11.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ashishdevtron ashishdevtron changed the title fix: implemented cache for storing cloud provider Enhancement: implemented cache for storing cloud provider Jan 27, 2024
@ashishdevtron ashishdevtron changed the title Enhancement: implemented cache for storing cloud provider fix: implemented cache for storing cloud provider Jan 27, 2024
@ashishdevtron ashishdevtron merged commit d714166 into main Jan 29, 2024
5 of 7 checks passed
@ashishdevtron ashishdevtron deleted the cloud-cache branch January 29, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: reduce API calls to multiple IMDS server everytime any posthog event is sent
3 participants