Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: active inactive user phase 2 #4624

Merged
merged 68 commits into from
Feb 20, 2024

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Feb 2, 2024

Description

Fixes #4640

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


kartik-579
kartik-579 previously approved these changes Feb 12, 2024
api/auth/user/UserRestHandler.go Show resolved Hide resolved
api/auth/user/UserRestHandler.go Show resolved Hide resolved
pkg/auth/user/RoleGroupService.go Outdated Show resolved Hide resolved
pkg/auth/user/RoleGroupService.go Outdated Show resolved Hide resolved
pkg/auth/user/RoleGroupService.go Outdated Show resolved Hide resolved
pkg/auth/user/RoleGroupService.go Outdated Show resolved Hide resolved
pkg/auth/user/UserService.go Outdated Show resolved Hide resolved
pkg/auth/user/UserService.go Outdated Show resolved Hide resolved
pkg/auth/user/UserService.go Outdated Show resolved Hide resolved
pkg/auth/user/UserService.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vikramdevtron vikramdevtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments

pkg/auth/user/helper/helper.go Outdated Show resolved Hide resolved
vikramdevtron
vikramdevtron previously approved these changes Feb 19, 2024
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Shivam-nagar23 Shivam-nagar23 merged commit c44db71 into main Feb 20, 2024
3 of 4 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the feat-active-inactive-user-phase-2 branch February 20, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Active / Inactive user - Phase II
3 participants