Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add milli unit in memory #4671

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: add milli unit in memory #4671

merged 1 commit into from
Feb 14, 2024

Conversation

gireesh-devtron
Copy link
Member

@gireesh-devtron gireesh-devtron commented Feb 14, 2024

Description

Fixes #4672

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gireesh-devtron gireesh-devtron merged commit de6f677 into main Feb 14, 2024
4 of 7 checks passed
@gireesh-devtron gireesh-devtron deleted the milli-mem-unit-oss branch February 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: we are not handling 'm' unit in build infra
4 participants