Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User api version for old apis #4685

Merged
merged 10 commits into from
Feb 19, 2024
Merged

fix: User api version for old apis #4685

merged 10 commits into from
Feb 19, 2024

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Feb 15, 2024

Description

Fixes #4684
Fixes #4687

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


api/bean/UserRequest.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
45.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Shivam-nagar23 Shivam-nagar23 merged commit f88c542 into main Feb 19, 2024
3 of 4 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the user-api-version branch February 19, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants