Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job workflow req volume mount #4693

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix: job workflow req volume mount #4693

merged 1 commit into from
Feb 19, 2024

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Feb 19, 2024

Description

Data Volume mount is not working in case of Jobs.

Fixes #4690

How Has This Been Tested?

  • Jobs with config maps
    • Data Volunteer
    • Env variables
  • Jobs with secrets
    • Data Volunteer
    • Env variables

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@Ash-exp Ash-exp self-assigned this Feb 19, 2024
@Ash-exp Ash-exp added the enhancement New feature or request label Feb 19, 2024
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ash-exp Ash-exp merged commit c2e7964 into main Feb 19, 2024
4 checks passed
@Ash-exp Ash-exp deleted the fix-job-cm-vol-mount branch February 19, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Not able to create and mount configmap as a data volume in Devtron job
2 participants