fix: git material url sanitised #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-exp
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
github-actions
bot
added
PR:Issue-verification-failed
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
nishant-d
approved these changes
Mar 5, 2024
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9498692 | Triggered | Generic Password | 5af4ee9 | pkg/gitops/GitOpsConfigService.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
raunit-verma
pushed a commit
to raunit-verma/devtron
that referenced
this pull request
Mar 11, 2024
* fix: git material url sanitised * renamed method --------- Co-authored-by: ShashwatDadhich <dadhichshashwat1808@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the user given git material (git repo url) is directly saved into database. If the user has given an additional trailing slash to the git material, in case PR based/ Tag based CI; we get the web-hook payload with the git repo url and we search the exact url in the database. For this case the unsanitized git material url (user given) will fail to match.This PR will fix this issue.
Fixes #4661
How Has This Been Tested?
Checklist:
Does this PR introduce a user-facing change?