Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trim space from git repo Url on create and update material #4787

Merged
merged 4 commits into from
Mar 13, 2024
Merged

fix: trim space from git repo Url on create and update material #4787

merged 4 commits into from
Mar 13, 2024

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Mar 13, 2024 •
edited

Description

Fixes #4769

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Shivam-nagar23 Shivam-nagar23 changed the title fix: trim space from git repo Url from workflow request to ci-runner fix: trim space from git repo Url on create and update material Mar 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Shivam-nagar23 Shivam-nagar23 merged commit 1620bf3 into main Mar 13, 2024
4 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the fix-trim-space-from-repository-url branch March 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Getting space in the Git repository for devtron applications
2 participants
@Shivam-nagar23 @nishant-d