Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Migrating to Go Modules #623

Merged
merged 10 commits into from
Aug 18, 2021
Merged

FEATURE: Migrating to Go Modules #623

merged 10 commits into from
Aug 18, 2021

Conversation

vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Aug 1, 2021

Description

Migrating to Go Modules, packaging dep to mod.

Fixes # (issue) : #616

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • argocd registry
  • argocd app object creation
  • argocd app object modify sync and delete
  • Dex Login
  • Configmap internal and external with subpath
  • Secret internal and exterrnal with filepermission
  • cd pipeline strategies, rollout, bluegreen, canary, recreate
  • charts deploy and configure
  • charts and normal application resource deletion
  • check app and charts app detail - terminal, logs, events

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles

TESTING
https://docs.google.com/spreadsheets/d/1kcccZ2lo4sGqVlvq4fuUIsLZC4AQ_6ylqC8QdfIt120/edit#gid=0

@vikramdevtron vikramdevtron self-assigned this Aug 1, 2021
@vikramdevtron vikramdevtron changed the title Migrating to Go Modules FEATURE: Migrating to Go Modules Aug 1, 2021
@vikramdevtron vikramdevtron linked an issue Aug 1, 2021 that may be closed by this pull request
@nishant-d nishant-d merged commit 7f310c1 into main Aug 18, 2021
@nishant-d nishant-d deleted the migration-dep-to-mod branch August 18, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration packaging dep to mod
2 participants