Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed hardcoded aws region #1

Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix: removed hardcoded aws region #1

merged 1 commit into from
Aug 18, 2021

Conversation

vikramdevtron
Copy link
Collaborator

@vikramdevtron vikramdevtron commented Aug 18, 2021

Description

aws region fixed as of now in image scanning service, passed it from devtron and ci runner to image scanner.

Fixes # (issue) : devtron-labs/devtron#650

Linked # (PR) : devtron-labs/devtron#657, devtron-labs/ci-runner#15

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Aws region received in event payload passed.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles

@vikramdevtron vikramdevtron self-assigned this Aug 18, 2021
@vikramdevtron vikramdevtron changed the title FIX: removed hardcoded aws region fix: removed hardcoded aws region Aug 18, 2021
@nishant-d nishant-d merged commit 6601e14 into main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants