fix: failing docker builds #24
Conversation
The docker build command was failing midway since `ENV` needs two parameters - the name of the variable, and its value. In the dockerfile, the variable had no value set against it - causing the error Fix this by introducing a new build arg, and setting this as the value for the environment variable
Update the docker build command in the readme to reflect changes introduced with the `AUTH_TOKEN` arg introduced in the dockerfile in the previous commit
|
Given that the |
Since the `GITHUB_TOKEN` being used as the environment variable in the docker image was needed (and not optional) - allowing docker builds to succeed, only to result in a crash when the container was run would be a waste of time. With this commit, the `AUTH_TOKEN` argument is mandatory for the `docker build` command to succeed. This greatly cuts down the response time to detect an error with the build command
|
@Abhinav-26 this should fix the issue with failing docker builds. I've also modified the dockerfile to ensure that the Line 10 in e3b3dfb If this is not needed, or should be a separate issue/PR by itself - let me know, I'll selectively roll this commit back! |
|
Hi There,
|
The Problem
As mentioned in #23, docker builds were failing with the error message
The cause of the issue was that the
ENVcommand in dockerfile expects two values - the name of the environment variable, and its value. TheGITHUB_TOKENenvironment variable had no value set against it, causing docker builds to failsilver-surfer/Dockerfile
Line 9 in 4580459
The Fix
This PR resolves #23
Added a new build argument named
AUTH_TOKENthat would then be set as the value for theGITHUB_TOKENenvironment variable in dockerfileUpdated the docker build command in
README!