Skip to content

Commit

Permalink
test: update size goldens for integration CLI tests
Browse files Browse the repository at this point in the history
Updates the size goldens for the integration CLI tests to
reflect the new payload with APF v13 and the CLI v13-next.7

Overall, there seems to be some increase in the polyfills
and a ~400b increase for the `main` bundles. This seems to
because with APF v13, the core package no longer uses the
downleveled `Object.assign`, but the spread operator directly.

ESbuild will then downlevel the spread to `__spreadProps` which
seems to come with more transitively-required helpers that
end up contributing to the ~400b increase. The spread is downleveled
even for the modern browsers this integration test targets, because
it is a trick to wrokaround a performance bug in V8. So the size
increase is reasonable given the runtime improvement. More details
here:
evanw/esbuild#951 (comment).
  • Loading branch information
devversion committed Oct 1, 2021
1 parent 82b2a08 commit 90242e1
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions goldens/size-tracking/integration-payloads.json
Expand Up @@ -15,8 +15,8 @@
"main": "TODO(i): temporarily increase the payload size limit from 17597 - this needs to be investigate further what caused the increase.",
"main": "Likely there is a missing PURE annotation https://github.com/angular/angular/pull/43344",
"main": "Tracking issue: https://github.com/angular/angular/issues/43568",
"main": 20064,
"polyfills": 36941
"main": 20409,
"polyfills": 37250
}
}
},
Expand All @@ -32,9 +32,9 @@
"cli-hello-world-ivy-i18n": {
"master": {
"uncompressed": {
"runtime": 1101,
"main": 137399,
"polyfills": 37641
"runtime": 929,
"main": 137444,
"polyfills": 37933
}
}
},
Expand Down

0 comments on commit 90242e1

Please sign in to comment.