Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Moya dependency to v15 #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kambala-decapitator
Copy link

While podspec change isn't strictly required, I changed it from >= to ~> for consistency with SPM.

@0k1019
Copy link

0k1019 commented Mar 31, 2022

It works well to me. in Podfile

pod 'MoyaSugar', :git => 'https://github.com/kambala-decapitator/MoyaSugar.git', :commit => 'eca6cfdb24cf1e8108ed7772bc6beb3643a80453'
pod 'MoyaSugar/RxSwift', :git => 'https://github.com/kambala-decapitator/MoyaSugar.git', :commit => 'eca6cfdb24cf1e8108ed7772bc6beb3643a80453'

But SPM is not working due to Moya issue

@kambala-decapitator
Copy link
Author

@0k1019 not sure why you're using my branch with Cocoapods: existing podspec in the main repo already allows using Moya v15

@0k1019
Copy link

0k1019 commented Mar 31, 2022

ss.dependency 'Moya', '>= 14.0.0-beta.2'

In master branch, there is no Moya v15 update.
So, I use your repo commit. If my action interferes you, I will remove it.

@kambala-decapitator
Copy link
Author

@0k1019 >= operator allows any later version unlike the ~> one which would've locked you to v14.

it doesn't interfere with me in any way, I'm just trying to make your Podfile setup simpler :)

@0k1019
Copy link

0k1019 commented Mar 31, 2022

Oh, My mistake. Think you so much!
My Podfile is simple thanks to your comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants