Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper function for setting cornerRadius #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cozzin
Copy link
Contributor

@cozzin cozzin commented Aug 29, 2019

Fix #113
Just add a setter for cornerRadius.
Actually, I have tried to make public backgroundView, but it does not work.

Copy link
Owner

@devxoul devxoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be a good alternative solution.

@Coeur
Copy link
Collaborator

Coeur commented Sep 7, 2019

I'm not a fan of this. In case of ambiguity, there is certainly a way to specify which method is the desired one. And solving the ambiguity for calling our method will not solve the ambiguity when you want to call the UIView method. It's better to remove cornerRadius entirely as I wrote in #113

@cozzin
Copy link
Contributor Author

cozzin commented Sep 8, 2019

@Coeur I know you want to make backgroundView as pulbic, but it does not work when I tested.

I tested like this:

ToastView.appearacne().backgroundView.layer.cornerRadius = 20

Or did you mean like this code?

ToastView.appearacne().backgroundView = CustomBackgroundView()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appearance properties names are ambiguous with some other frameworks
3 participants