Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement launch on startup feature #68

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

crowjdh
Copy link
Contributor

@crowjdh crowjdh commented Jan 27, 2017

This PR resolves #5 by using ServiceManagement.framework to register allkdic into login items.

Few concerns are:

  1. The version of CocoaPods has been updated to 1.1.1. I don't know if this change matters to you.
  2. Development team has been changed. This is my first contribution to xcode project, so I'm not sure what to do.

@devxoul
Copy link
Owner

devxoul commented Jan 31, 2017

@crowjdh, thanks for your work. Have you tested it? It doesn't seem to work. 🤔

@crowjdh
Copy link
Contributor Author

crowjdh commented Jan 31, 2017

Ah, sorry I forgot to mention but there's a checkbox in the preference window which toggles 'auto startup on login'. AFAIK, this is mandatory for MacOS apps to be released in Mac Appstore.

I've tested on MacOS Sierra, so I'm not sure about previous versions. Please let me know if it doesn't work.

@devxoul
Copy link
Owner

devxoul commented Jan 31, 2017

Yeah, I made that checkbox checked and restart my mac but it didn't launch automatically. 🤔 How did you test?

@devxoul
Copy link
Owner

devxoul commented Jan 31, 2017

Oh, it should have been on Application folder. It works now. Thanks!

@devxoul devxoul changed the base branch from master to launch-on-startup January 31, 2017 07:50
@devxoul devxoul merged commit 45aec7c into devxoul:launch-on-startup Jan 31, 2017
@crowjdh
Copy link
Contributor Author

crowjdh commented Jan 31, 2017

Great! Sorry for insufficient information though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants