once('pipe' | 'unpipe') resolves to Readable

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v2.0.2 2017-10-10
+
+  * Typescript: `once('pipe' | 'unpipe')` resolves to `Readable`.
+
 ## v2.0.1 2017-10-06
 
   * Do not use UMD import internally.

examples/bsmtp-client-ts.ts

@@ -39,15 +39,16 @@ import * as net from 'net'
 
 import byline = require('byline')
 
-const [host = 'localhost', port = '25'] = process.argv.slice(2, 4)
+const host = process.argv[2] || 'localhost'
+const port = Number(process.argv[3]) || 25
 
 const socket = new PromiseDuplex(new net.Socket())
 const stdin = new PromiseReadable(byline(process.stdin, { keepEmptyLines: true }))
 const stdout = new PromiseWritable(process.stdout)
 
-socket.stream.connect(Number(port), host, client)
+socket.stream.connect(port, host, client)
 
-async function client (arg: any): Promise<void> {
+async function client (): Promise<void> {
   try {
     // which line for DATA command?
     let dataLine = 0

examples/bsmtp-client.js

@@ -38,15 +38,16 @@ const { PromiseDuplex } = require('../lib/promise-duplex')
 const net = require('net')
 const byline = require('byline')
 
-const [host = 'localhost', port = '25'] = process.argv.slice(2, 4)
+const host = process.argv[2] || 'localhost'
+const port = Number(process.argv[3]) || 25
 
 const psocket = new PromiseDuplex(new net.Socket())
 const pstdin = new PromiseReadable(byline(process.stdin, {keepEmptyLines: true}))
 const pstdout = new PromiseWritable(process.stdout)
 
 psocket.stream.connect(port, host, client)
 
-async function client (arg) {
+async function client () {
   try {
     // which line for DATA command?
     let dataLine = 0

lib/promise-duplex.d.ts

@@ -2,9 +2,9 @@
 
 import { PromiseReadable } from 'promise-readable'
 import { PromiseWritable } from 'promise-writable'
-import * as stream from 'stream'
+import { Readable, Duplex } from 'stream'
 
-export declare class PromiseDuplex<TDuplex extends stream.Duplex> extends PromiseReadable<TDuplex> implements PromiseWritable<TDuplex> {
+export declare class PromiseDuplex<TDuplex extends Duplex> extends PromiseReadable<TDuplex> implements PromiseWritable<TDuplex> {
   readonly stream: TDuplex
   readonly readable: PromiseReadable<TDuplex>
   readonly writable: PromiseWritable<TDuplex>
@@ -17,13 +17,9 @@ export declare class PromiseDuplex<TDuplex extends stream.Duplex> extends Promis
   write (chunk: string | Buffer, encoding?: string): Promise<number>
   writeAll (content: string | Buffer, chunkSize?: number): Promise<number>
 
-  once (event: 'close'): Promise<void>
-  once (event: 'end'): Promise<void>
-  once (event: 'error'): Promise<void>
-  once (event: 'finish'): Promise<void>
+  once (event: 'close' | 'end' | 'error' | 'finish'): Promise<void>
   once (event: 'open'): Promise<number>
-  once (event: 'pipe'): Promise<NodeJS.ReadableStream>
-  once (event: 'unpipe'): Promise<NodeJS.ReadableStream>
+  once (event: 'pipe' | 'unpipe'): Promise<Readable>
 
   end (): Promise<void>
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "promise-duplex",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "Return promise for duplex stream",
   "main": "lib/promise-duplex.js",
   "typings": "lib/promise-duplex.d.ts",
@@ -23,12 +23,12 @@
     "node": ">=4.0.0"
   },
   "dependencies": {
-    "promise-readable": "^2.0.0",
-    "promise-writable": "^2.0.1"
+    "promise-readable": "^2.1.0",
+    "promise-writable": "^2.1.1"
   },
   "devDependencies": {
     "@types/byline": "^4.2.31",
-    "@types/node": "^8.0.33",
+    "@types/node": "^8.0.34",
     "byline": "^5.0.0",
     "chai": "^4.1.2",
     "chai-as-promised": "^7.1.1",

tsconfig.json

@@ -1,12 +1,10 @@
 {
   "compilerOptions": {
     "module": "commonjs",
-    "removeComments": false,
+    "noImplicitReturns": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
     "strict": true,
-    "target": "ES2017",
-    "typeRoots" : [
-      "./lib",
-      "./node_modules/@types"
-    ]
+    "target": "ES2017"
   }
 }

tslint.json

@@ -3,10 +3,9 @@
     "tslint:recommended",
     "tslint-config-standard"
   ],
-  "jsRules": {},
   "rules": {
     "no-conditional-assignment": false,
     "no-console": [true, "log"],
-    "triple-equals": [true, "allow-null-check"]
+    "no-unused-variable": false
   }
 }