Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct return type for Redis.quit() #49

Merged
merged 1 commit into from Oct 3, 2020
Merged

Conversation

dex4er
Copy link
Owner

@dex4er dex4er commented Oct 3, 2020

Fixes:

test/lib/mock-ioredis.ts:48:3 - error TS2416: Property 'quit' in type 'MockIORedis' is not assignable to the same property in base type 'Redis'.
  Type '() => Promise<string>' is not assignable to type '{ (callback: Callback<"OK">): void; (): Promise<"OK">; }'.
    Type 'Promise<string>' is not assignable to type 'Promise<"OK">'.
      Type 'string' is not assignable to type '"OK"'.

48   quit(): Promise<string> {
     ~~~~

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 89.13% when pulling c32d62c on bugfix-mock-ioredis into 534019c on master.

@dex4er dex4er merged commit d837fa6 into master Oct 3, 2020
@dex4er dex4er deleted the bugfix-mock-ioredis branch October 3, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants