Skip to content

Commit

Permalink
Merge pull request #972 from rithujohn191/github-doc
Browse files Browse the repository at this point in the history
Documentation/github-connector: warn user that GitHub email id should be public.
  • Loading branch information
rithujohn191 committed Jun 20, 2017
2 parents 15242a8 + d6c1b0f commit 3493e30
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions Documentation/github-connector.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ One of the login options for dex uses the GitHub OAuth2 flow to identify the end

When a client redeems a refresh token through dex, dex will re-query GitHub to update user information in the ID Token. To do this, __dex stores a readonly GitHub access token in its backing datastore.__ Users that reject dex's access through GitHub will also revoke all dex clients which authenticated them through GitHub.

## Caveats

* Please note that in order for a user to be authenticated via GitHub, the user needs to mark their email id as public on GitHub. This will enable the API to return the user's email to Dex.
* Currently, authentication via GitHub allows users outside of the `Org` specified in the connector to login. This is being tracked by [issue #920][issue-920].

## Configuration

Register a new application with [GitHub][github-oauth2] ensuring the callback URL is `(dex issuer)/callback`. For example if dex is listening at the non-root path `https://auth.example.com/dex` the callback would be `https://auth.example.com/dex/callback`.
Expand Down Expand Up @@ -65,3 +70,4 @@ connectors:
```

[github-oauth2]: https://github.com/settings/applications/new
[issue-920]: https://github.com/coreos/dex/issues/920

0 comments on commit 3493e30

Please sign in to comment.