Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"select another login method" link causes database error #1849

Closed
tomqwpl opened this issue Oct 30, 2020 · 1 comment
Closed

"select another login method" link causes database error #1849

tomqwpl opened this issue Oct 30, 2020 · 1 comment

Comments

@tomqwpl
Copy link
Contributor

tomqwpl commented Oct 30, 2020

If you select a login method that requires the password entry dialog to be displayed, there's a link at the bottom "select another login method". If you click on this, then select a different login method you get an error screen with "database error".
In the Dex log there is "connector is already set for this auth request".
So it looks like Dex doesn't actually support changing to a different login method.

@al45tair
Copy link
Contributor

This is a symptom of the problem mentioned in #646, namely that the authorisation request is persisted too early.

al45tair added a commit to WorldProgrammingLtd/dex that referenced this issue Nov 16, 2020
Rather than creating the auth request when the user hits /auth, pass
the arguments through to /auth/{connector} and have the auth request
created there.  This prevents a database error when using the "Select
another login method" link, and also avoids a few other error cases.

Fixes dexidp#1849, dexidp#646.

Signed-off-by: Alastair Houghton <alastair@alastairs-place.net>
elffjs pushed a commit to DIMO-Network/dex that referenced this issue Jun 27, 2022
Rather than creating the auth request when the user hits /auth, pass
the arguments through to /auth/{connector} and have the auth request
created there.  This prevents a database error when using the "Select
another login method" link, and also avoids a few other error cases.

Fixes dexidp#1849, dexidp#646.

Signed-off-by: Alastair Houghton <alastair@alastairs-place.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants