Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.35.0 does not fetch groups from google anymore #2694

Closed
3 tasks done
amiga23 opened this issue Oct 4, 2022 · 2 comments · Fixed by #2695 or #2696
Closed
3 tasks done

Version 2.35.0 does not fetch groups from google anymore #2694

amiga23 opened this issue Oct 4, 2022 · 2 comments · Fixed by #2695 or #2696
Assignees
@sagikazarmark
Labels
kind/bug kind/regression

Comments

@amiga23
Copy link

amiga23 commented Oct 4, 2022

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.

Version

2.35.0

Storage Type

Kubernetes

Installation Type

Official container image

Expected Behavior

After succesfull login, the groups should be shown in the log and be part of the OIDC token

Actual Behavior

The groups are empty in the logs and in the OIDC token

Steps To Reproduce

  1. Have an installation with Version 2.34.0 which uses Google for Authentication with group fetch enabled.
  2. Login and check if groups are there. -> It works with 2.34.0 and earlier
  3. Upgrade from 2.34.0 to 2.35.0
  4. Login and check if groups are in logs and OIDC Token. -> Groups are empty, no further hint in the logs

Additional Information

No response

Configuration

No response

Logs

No response
@sagikazarmark
Copy link
Member

Looks like the "fix" introduced in #2679 was incorrect.

@sagikazarmark sagikazarmark mentioned this issue Oct 4, 2022
Merged
This was linked to pull requests Oct 4, 2022
Make admin email optional when no service account path is configured #2695
Merged
Backport #2694 to v2.35.x #2696
Merged
@sagikazarmark sagikazarmark self-assigned this Oct 4, 2022
sagikazarmark added a commit that referenced this issue Oct 4, 2022
@sagikazarmark
Merge pull request #2696 from dexidp/backport-2694
2027413 
Backport #2694 to v2.35.x
xtremerui pushed a commit to concourse/dex that referenced this issue Oct 4, 2022
upstream dex release: v2.35.1
a3ae169 
The official container image for this release can be pulled from
```
ghcr.io/dexidp/dex:v2.35.1
```

<!-- Release notes generated using configuration in .github/release.yml at v2.35.1 -->

## What's Changed
### Bug Fixes 🐛
* Backport dexidp#2694 to v2.35.x by @sagikazarmark in dexidp#2696

**Full Changelog**: dexidp/dex@v2.35.0...v2.35.1
@amiga23
Copy link
Author

amiga23 commented Oct 4, 2022

v2.35.1 works for me, thank you

@taisph taisph mentioned this issue Oct 5, 2022
Closed
3 tasks
@sagikazarmark sagikazarmark mentioned this issue Oct 5, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagikazarmark sagikazarmark

Labels
kind/bug kind/regression
Projects
None yet
Milestone
No milestone
2 participants
@amiga23 @sagikazarmark