add client request timeout #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
reviewed
Sep 26, 2017
storage/kubernetes/client.go
Outdated
| client: &http.Client{Transport: t}, | ||
| client: &http.Client{ | ||
| Transport: t, | ||
| Timeout: 30 * time.Second, |
There was a problem hiding this comment.
can we make this shorter? e.g. 15 seconds. There's no reason any of these requests should take 30 seconds.
we definitely don't want to depend on the server to time it out even if it will. |
rphillips
force-pushed
the
fixes/http_client_timeout
branch
from
5d85801
to
1c330e5
Compare
ericchiang
approved these changes
Sep 26, 2017
rphillips
force-pushed
the
fixes/http_client_timeout
branch
from
1c330e5
to
0318cd9
Compare
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
add client request timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does the http.Client ever get a timeout attached to it for requests that timeout? Or would the server timeout the request?