Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add ids to elements for testing automation #1097

Merged
merged 1 commit into from
Oct 10, 2017
Merged

tests: add ids to elements for testing automation #1097

merged 1 commit into from
Oct 10, 2017

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Oct 10, 2017

In the tectonic-installer we are doing some tests to check if the console is up and running. Just adding some ids for better tests and to not rely on css or xpath.

Please let me know what do you think.

Copy link
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. lgtm

@ericchiang ericchiang merged commit 3849abb into dexidp:master Oct 10, 2017
@cpanato cpanato deleted the add_ids_test_automation branch October 10, 2017 18:39
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
tests: add ids to elements for testing automation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants