connector: implement LinkedIn connector #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
reviewed
Oct 25, 2017
connector/linkedin/linkedin.go
Outdated
| client := c.oauth2Config.Client(ctx, token) | ||
| profile, err := c.profile(ctx, client) | ||
| if err != nil { | ||
| return identity, fmt.Errorf("github: get profile: %v", err) |
connector/linkedin/linkedin.go
Outdated
|
|
||
| identity = connector.Identity{ | ||
| UserID: profile.ID, | ||
| Username: profile.FirstName + " " + profile.LastName, |
There was a problem hiding this comment.
nit: we should be smarter about this value. e.g. ensure that the FirstName and LastName are actually set.
connector/linkedin/linkedin.go
Outdated
| identity = connector.Identity{ | ||
| UserID: profile.ID, | ||
| Username: profile.FirstName + " " + profile.LastName, | ||
| Email: profile.Email, |
There was a problem hiding this comment.
Please error if profile.Email isn't set.
There was a problem hiding this comment.
That's seems like an impossible condition. This is the main email that was used for registration and we always ask permission for r_emailaddress claim.
I'd add the check just to be sure anyway.
|
|
||
| func (c *linkedInConnector) profile(ctx context.Context, client *http.Client) (p profile, err error) { | ||
| // https://developer.linkedin.com/docs/fields/basic-profile | ||
| req, err := http.NewRequest("GET", apiURL+"/people/~:(id,first-name,last-name,email-address)", nil) |
There was a problem hiding this comment.
this is a really weird URL. ha
|
This conflicts with some additions in #1100 Mind rebasing? |
connector/linkedin implements authorization strategy via LinkedIn's OAuth2 endpoint + profile API. It doesn't implement RefreshConnector as LinkedIn doesn't provide any refresh token at all (https://developer.linkedin.com/docs/oauth2, Step 5 — Refresh your Access Tokens) and recommends ordinary AuthCode exchange flow when token refresh is required. Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Do Refresh() by querying user's profile data. Since LinkedIn doesn't provide refresh tokens at all, and the access tokens have 60 days expiration, refresh tokens issued by Dex will fail to update after 60 days. Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
ericchiang
approved these changes
Oct 27, 2017
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
connector: implement LinkedIn connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connector/linkedin implements authorization strategy via LinkedIn's
OAuth2 endpoint + profile API.
It doesn't implement RefreshConnector as LinkedIn doesn't provide any
refresh token at all (https://developer.linkedin.com/docs/oauth2, Step 5
— Refresh your Access Tokens) and recommends ordinary AuthCode exchange
flow when token refresh is required.