authproxy.md: strip X-Remote-User #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stapelberg can you make a change to dex's code as well? I'd like for dex's server to remove any X-Remote-* header values sent to |
|
Sure. Done. |
ericchiang
reviewed
Oct 26, 2017
server/server.go
Outdated
| r.HandleFunc(path.Join(issuerURL.Path, "/callback"), func(w http.ResponseWriter, r *http.Request) { | ||
| // Strip the X-Remote-User header to prevent security issues on | ||
| // misconfigured authproxy connector setups. | ||
| r.Header.Del("X-Remote-User") |
There was a problem hiding this comment.
Let's future proof this against other headers:
for key := range r.Header {
if strings.HasPrefix(strings.ToLower(key), "x-remote-") {
r.Header.Del(key)
}
}
follow-up for dexidp#1100
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
authproxy.md: strip X-Remote-User
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up for #1100