connector/oidc: remove test that talks to the internet #1109

ericchiang · 2017-10-27T20:43:31Z

Notice this flake here https://travis-ci.org/coreos/dex/jobs/293766424

Unit tests shouldn't talk to the internet.

=== RUN   TestOidcConnector_LoginURL
--- FAIL: TestOidcConnector_LoginURL (30.47s)
	oidc_test.go:79: failed to open connector: failed to get provider: Get https://accounts.google.com/.well-known/openid-configuration: dial tcp 108.177.10.84:443: i/o timeout

@RoguePanda noticed this was added in #974. Removing it for now. If you'd like to follow up with a PR to add the test back in please do.

cc @rithujohn191

rithujohn191

LGTM

connector/oidc: remove test that talks to the internet

connector/oidc: remove test that talks to the internet

6475ce1

rithujohn191 approved these changes Oct 30, 2017

View reviewed changes

rithujohn191 merged commit 943e23c into dexidp:master Oct 30, 2017

ericchiang deleted the oidc-test branch October 30, 2017 18:18

mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019

Merge pull request dexidp#1109 from ericchiang/oidc-test

68d9026

connector/oidc: remove test that talks to the internet

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

connector/oidc: remove test that talks to the internet #1109

connector/oidc: remove test that talks to the internet #1109

ericchiang commented Oct 27, 2017

rithujohn191 left a comment

connector/oidc: remove test that talks to the internet #1109

connector/oidc: remove test that talks to the internet #1109

Conversation

ericchiang commented Oct 27, 2017

rithujohn191 left a comment

Choose a reason for hiding this comment