Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license: add bill of materials. #1152

Merged
merged 1 commit into from
Dec 19, 2017
Merged

license: add bill of materials. #1152

merged 1 commit into from
Dec 19, 2017

Conversation

diegs
Copy link
Contributor

@diegs diegs commented Dec 19, 2017

No description provided.

@diegs diegs self-assigned this Dec 19, 2017
Makefile Outdated
@@ -36,6 +36,8 @@ release-binary:
revendor:
@glide up -v
@glide-vc --use-lock-file --no-tests --only-code
@CGO_ENABLED=1 go get github.com/coreos/license-bill-of-materials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin this instead of running go get?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericchiang pin how?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned to a specific version instead of grabbing master every time. Either by vendoring the tool into Dex (what we do with the go proto generator) or by grabbing a release binary at a specific tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. There are no release binaries, so I'll figure out how to vendor it.

@diegs
Copy link
Contributor Author

diegs commented Dec 19, 2017

@ericchiang PTAL

@ericchiang
Copy link
Contributor

@diegs tried to run this locally. Looks like there's an additional dependency?

$ make bin/license-bill-of-materials 
vendor/github.com/coreos/license-bill-of-materials/license-bill-of-materials.go:19:2: cannot find package "github.com/pmezard/licenses/assets" in any of:
        /home/eric/src/github.com/coreos/dex/vendor/github.com/pmezard/licenses/assets (vendor tree)
        /usr/local/go/src/github.com/pmezard/licenses/assets (from $GOROOT)
        /home/eric/src/github.com/pmezard/licenses/assets (from $GOPATH)
make: *** [Makefile:80: bin/license-bill-of-materials] Error 1

@diegs
Copy link
Contributor Author

diegs commented Dec 19, 2017

@ericchiang bumped the vendor with the fix.

@ericchiang ericchiang merged commit b5baf6b into dexidp:master Dec 19, 2017
@diegs diegs deleted the bom branch December 19, 2017 18:32
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
license: add bill of materials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants