Add allowedGroups option for clients config #1583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
nabokihms
force-pushed
the
add-client-allowed-groups
branch
from
3edd8fc
to
41303eb
Compare
|
Now, this branch grows from actual master. This feature can still be convenient for someone. So, I will try to keep this branch up to date. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes it may be necessary to restrict access to applications for certain groups.
It's easy to achieve by adding the
allowedGroupsoption, which is represented as a list of groups, to oauth2-client configuration.For example:
We want to allow access to all django admin panels for users in
django-adminsgroup.This is a proof of concept because the option reading added only for Kubernetes storage provider. However, I will do similar changes for the rest of the providers if I have some feedback.