Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor for static key strategy #1802

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

xtremerui
Copy link
Contributor

Allow user to provide a static key for signing without rotation.

Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtremerui can you please rebase your PR? And also signoff your commits?

Also, it'd be nice to hear more about your use case for Dex. I recall you maintaining a fork, but PRs like this rather tells that you use Dex as a "library" (or rather configure it in a different way in your own app).

TBH I'm usually not a huge fan of (re)using application code in other applications, but given you seem to be an active user, you might have a story to tell. Also, given that there is no way to add custom connectors at the moment, this could actually be the only way to provide better support for that use case as well.

@sagikazarmark sagikazarmark added this to the v2.26.0 milestone Oct 1, 2020
@xtremerui
Copy link
Contributor Author

Thx for your time @sagikazarmark reviewing this.

The reason that we want to have a static key could be found here concourse/concourse@1199aae

Concoures can run of multiple web nodes and each of that has its own dex server. If the key is by default rotating after 6/24 hours, the rotated key will be different in each of them. So we want to make sure there is a default way to deploy Concourse with multiple web nodes that operator don't need to do anything special to sync the signing keys between dex servers.

Co-authored-by: Josh Winters <jwinter@pivotal.io>
Signed-off-by: Rui Yang <ruiya@vmware.com>
@sagikazarmark
Copy link
Member

Gotcha! I think the docker failure is normal at this point, so I think this is good to go.

@sagikazarmark sagikazarmark merged commit d4c3a35 into dexidp:master Oct 1, 2020
@xtremerui xtremerui deleted the pr/static-public-key-sync branch October 1, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants