fix: Bump golangci-lint version and fix some linter's problems #1837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a naughty warning in the "Run linter" CI job logs:
Examples: 1, 2, 3
Bumping the golangci-lint version to the actual one fixes the problem. It requires golangci-linter configuration changes because the
enable-all
option was marked as deprecated. Users have to use thedisable-all
option and manually enable linters they want.I also fixed some style problems to enable the following linters:
Think it might be a useful improvement.