server: better UX when remote ID already exists #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #166 |
|
Ok, now you get taken to a page where you can login directly. Not sure how I feel about it though - a new session has to be created, and you get "logged in" in dex's mind even if you don't click the link. Take a look and tell me what you think. |
| } | ||
|
|
||
| // finally, we can create a valid redirect URL for them. | ||
| redirURL, err := s.Login(ses.Identity, newSessionKey) |
|
I dig it. |
Instead of cryptic message with nowhere to, give them the choice to login with that account or register.
bobbyrullo
added a commit
that referenced
this pull request
Dec 24, 2015
server: better UX when remote ID already exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of cryptic message with nowhere to, give them the choice to
login with that account or register.