Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Build Dex in parallel #2831

Closed
wants to merge 24 commits into from
Closed

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented Feb 16, 2023

Overview

This is a proof of concept of CI refactoring.

  1. Run the build in parallel.
  2. Use Go for cross-compilation instead of QEMU.
  3. Bump Go version (1.20) and golangci-lint (1.51).
  4. Use runners with more CPU. Use standard lightweight runners. They are always available and pick up jobs faster.
  5. Remove the Docker job.

What this PR does / why we need it

This PR is supposed to help reduce the number of random freezes during cross-compilation and consume fewer resources/time.

Special notes for your reviewer

Do we need integration tests for final builds to be sure that Dex works as expected? Do we want to execute tests for different architectures?

Does this PR introduce a user-facing change?

chore: Build Dex in parallel and cross-compile with Go

@nabokihms nabokihms added the release-note/enhancement Release note: Enhancements label Feb 16, 2023
@nabokihms nabokihms force-pushed the parallel-builds branch 29 times, most recently from bfaefdd to 5ed5bda Compare February 17, 2023 12:28
nabokihms and others added 23 commits March 21, 2023 16:44
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: Márk Sági-Kazár <sagikazarmark@users.noreply.github.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms force-pushed the parallel-builds branch 2 times, most recently from 2f54947 to a8ce622 Compare March 22, 2023 11:37
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms
Copy link
Member Author

@sagikazarmark
I refactored the release-binary logic to cross-compile binaries in a container. It should fix some issues of the previous implementation and resolve some of your concerns.

Could you please take a look and share your opinion?

@nabokihms
Copy link
Member Author

Closing if favor of #2898 (comment)

@nabokihms nabokihms closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Release note: Enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants