verify access tokens by checking getuserinfo during a token exchange #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankhliao
force-pushed
the
access-tokens-with-userinfo
branch
from
ddf4edc
to
ecb5377
Compare
nabokihms
requested changes
Jul 6, 2023
seankhliao
force-pushed
the
access-tokens-with-userinfo
branch
from
daf59cd
to
b46d37f
Compare
The provider.Verifier.Verify endpoint we were using only works with ID tokens. This isn't an issue with systems which use ID tokens as access tokens (e.g. dex), but for systems with opaque access tokens (e.g. Google / GCP), those access tokens could not be verified. Instead, check the access token against the getUserInfo endpoint. Co-authored-by: Maksim Nabokikh <max.nabokih@gmail.com> Signed-off-by: Sean Liao <sean+git@liao.dev>
seankhliao
force-pushed
the
access-tokens-with-userinfo
branch
from
b46d37f
to
c2a7c62
Compare
|
Not sure which question you were referring to? |
|
@seankhliao, it was the question about what you have already fixed. Now everything seems fine 👍 |
palexster
pushed a commit
to palexster/dex
that referenced
this pull request
Oct 4, 2023
…exidp#3031) The provider.Verifier.Verify endpoint we were using only works with ID tokens. This isn't an issue with systems which use ID tokens as access tokens (e.g. dex), but for systems with opaque access tokens (e.g. Google / GCP), those access tokens could not be verified. Instead, check the access token against the getUserInfo endpoint. Signed-off-by: Sean Liao <sean+git@liao.dev> Co-authored-by: Maksim Nabokikh <max.nabokih@gmail.com>
michaelliau
pushed a commit
to FlockFreight/dex
that referenced
this pull request
Oct 4, 2023
…exidp#3031) The provider.Verifier.Verify endpoint we were using only works with ID tokens. This isn't an issue with systems which use ID tokens as access tokens (e.g. dex), but for systems with opaque access tokens (e.g. Google / GCP), those access tokens could not be verified. Instead, check the access token against the getUserInfo endpoint. Signed-off-by: Sean Liao <sean+git@liao.dev> Co-authored-by: Maksim Nabokikh <max.nabokih@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Followup on #2806 for better access token handling.
verify access tokens by checking getuserinfo during a token exchange
What this PR does / why we need it
The provider.Verifier.Verify endpoint we were using only works with ID tokens. This isn't an issue with systems which use ID tokens as access tokens (e.g. dex), but for systems with opaque access tokens (e.g. Google / GCP), those access tokens could not be verified. Instead, check the access token against the getUserInfo endpoint.
Special notes for your reviewer
Does this PR introduce a user-facing change?