Introduce a dedicated pkg for featureflags #3278
Merged
+49
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
nabokihms
force-pushed
the
featureflags-pkg
branch
from
d312d82
to
0834824
Compare
sagikazarmark
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Dex is a piece of software used in production in many companies. Introducing breaking changes is what we try to avoid.
It makes sense to hide some crucial changes behind a feature flag. Before, we introduced a couple of particular environment variables for this purpose.
This PR generalizes the approach for new feature flags in Dex.
What this PR does / why we need it
How to implement, use, and find a feature flag in the code needs to be clarified. This PR aims to define and standardize the concept of feature flags.
Special notes for your reviewer
The improvement to make the codebase cleaner.