tests: add HandleTokenFunc test #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| req.Header.Set("Content-Type", "application/x-www-form-urlencoded") | ||
| basicAuthEncode := base64.URLEncoding.EncodeToString([]byte(tt.creds)) | ||
| req.Header.Set("Authorization", "Basic "+basicAuthEncode) |
There was a problem hiding this comment.
Please use http.Request.SetBasicAuth
|
Some inline comments, but other than that lgtm. |
|
|
||
| fx, err := makeTestFixtures() | ||
| if err != nil { | ||
| t.Errorf("could not run test fixtures") |
There was a problem hiding this comment.
Need to t.Fatal here since the test can't continue if this fails. Also please print the error:
t.Fatalf("could not run test fixtures: %v", err)
adrianlop
force-pushed
the
408-test-handleToken
branch
from
28bfed3
to
d3d2db8
Compare
|
@ericchiang thanks for your comments! I reviewed the PR. |
|
lgtm. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds test for HandleTokenFunc
Fixes #408