Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/k8s: YAML brevity via references, minimum resource requests #424

Merged
merged 1 commit into from Apr 25, 2016
Merged

contrib/k8s: YAML brevity via references, minimum resource requests #424

merged 1 commit into from Apr 25, 2016

Conversation

andrewstuart
Copy link
Contributor

  • Add resource requests for deployments
  • Add readiness probe for master
  • Use YAML references for easier maintenance/readability

@andrewstuart
contrib/k8s: YAML brevity via references, add min. resource requests
c459e09 
- Add resources for deployments
- Add readiness probe for master
- Use YAML references for easier maintenance/readability
@bobbyrullo
Copy link
Contributor

LGTM - I dig the YAML anchors.

@bobbyrullo bobbyrullo merged commit 4c4f4c0 into dexidp:master Apr 25, 2016
@andrewstuart
Copy link
Contributor Author

Sweet! Yeah, I was surprised that they worked right out of the box, and yet I've never really seen any k8s examples/docs using them.

@andrewstuart andrewstuart deleted the feat/further-kube-updates branch April 25, 2016 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewstuart @bobbyrullo