Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go 1.6.2 for docker go build #433

Merged
merged 2 commits into from May 4, 2016

Conversation

chris-rock
Copy link
Contributor

I switched to the official golang image. Not sure if there was a reason to use the dex-builder image?

supersedes #406
fixes #404

@ericchiang
Copy link
Contributor

Never cared for the official Go image (it's like 750MB for a 80MB Go distro, ships with a python interpreter, etc), but it looks like the dex-builder is just a derivative of it anyway.

$ cat Dockerfile-builder
FROM golang:1.6

RUN go get golang.org/x/tools/cmd/cover
RUN go get golang.org/x/tools/cmd/vet
RUN go get github.com/tools/godep

Should be fine, we use vendor now, and I believe vet and cover are now built into the tool.

We should also remove Dockerfile-builder if we're going to delete this.

@bobbyrullo any objections?

@bobbyrullo
Copy link
Contributor

Seems reasonable to me

@chris-rock
Copy link
Contributor Author

Updated the PR to remove the Dockerfile-builder as well

@ericchiang
Copy link
Contributor

LGTM. Thanks for the update!

@ericchiang ericchiang merged commit ea4c04f into dexidp:master May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Go 1.6.1 and 1.5.4
3 participants